parse JSON string resolved from kvr #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
commented
Jul 5, 2024
| @@ -5,12 +5,11 @@ import { ConfigurationSetting } from "@azure/app-configuration"; | |||
| export interface IKeyValueAdapter { | |||
| /** | |||
| * Determine whether the adapter applies to a configuration setting. | |||
| * Note: A setting is expected to be processed by at most one adapter. | |||
There was a problem hiding this comment.
@avanigupta
Here the use case is to store some correlated configs altogether into an object and JSON.stringify it. Maybe for some security reason, put it into a key vault, marking it as application/json. For JavaScript developers it looks a valid case. We should auto-parse it as we see the content type.
In dotnet, only one key value adapter would process a setting. But here to support the case, we should remove the constraints. The adapters should work like pipeline processors. We can rename it if you feel strange about the name "adapter".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #78
Now if a JSON string is stored in Key Vault with content type "application/json", it will be loaded as parsed object instead of a raw string.