Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KEDA 2.0 for func kubernetes commands #2144

Closed
jeffhollan opened this issue Aug 6, 2020 · 10 comments
Closed

Support KEDA 2.0 for func kubernetes commands #2144

jeffhollan opened this issue Aug 6, 2020 · 10 comments
Assignees
Labels

Comments

@jeffhollan
Copy link

KEDA 2.0 will go into beta soon, with a 2.0 release planned for later this year. There are some minor changes to the spec so the function core tools will need to be able to generate the latest one.

https://keda.sh/docs/2.0/migration/

Ideally there could still be a flag for backwards compat to KEDA 1.0? Or maybe we make people opt-in to keda 2.0? func kubernetes deploy --keda-version 2 or something?

Will just need live before like end of October

// @apawast @anirudhgarg @TsuyoshiUshio

@tomkerkhove
Copy link
Member

Would be good to use 2.0 as default and provide capability to use 1.0 for backward compatibility maybe?

@anthonychu
Copy link
Member

I think it might be safer for deploy to check which version is installed in the cluster and be smart about what to do. A --keda-version flag might still be needed when the version is unknown (like when using --dry-run).

@tomkerkhove
Copy link
Member

Even better proposal!

@jeffhollan
Copy link
Author

FYI - 2.0 is now in beta, scheduled to be default in coming months. Just flagging in that we likely want to try to book the work for this before end of October

@tomkerkhove
Copy link
Member

@TsuyoshiUshio
Copy link
Contributor

It is a good idea! I agree with @anthonychu 's idea. I have a customer who wants to use v2 for the production as a backend of a service. However, My scalelogic prevent to use it, So I provide them a hotfix with branch and push keda image to dockerhub. Probably, if we operate it, these case happens, then we can easy to provide hot fix and customer can rollback old version if there is a problem for a new release.

@jeffhollan
Copy link
Author

Just pinging here, looking for end of October / early November release for KEDA 2.0 and will start being default. Would be good to track these changes. All the changes between 1 and 2.0 are covered here https://keda.sh/docs/2.0/migration/ - added to PM board for planning / prioritization

@tomkerkhove
Copy link
Member

I'll pick this up in one of the coming days

@pragnagopa
Copy link
Member

cc @fabiocav
Tagging myself (@pragnagopa), @ankitkumarr , @gzuber for reviews

@pragnagopa
Copy link
Member

Closing as addressed in referenced PR.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants