@zboukheloua, thanks for submitting this issue for the avm/res/desktop-virtualization/workspace module!

Thanks for reporting this bug. Will review it.

Very strange indeed. Thanks @moisesjgomez for looking into it - I can't see any obvious issue with the deployment. I guess to troubleshoot we'd need to deploy one of the test cases with diagnosticSettings manually and try to replicate it

Following up on this as I haven't resolved yet but should have more updates the following week.

Hello team due to current priorities I've not been able to get to the bottom of this. I will follow up again next week as I should have some more time. Thanks.

Hi, this issues is still happening with the workspace:0.7.1 module. I see in deployment that the parameters are passed but when checking the workspace diagnostics settings they are empty

cc: @moisesjgomez

@jkamping @AlexanderSehr Thank you, will prioritize this fix this upcoming week.

No status update yet on this

Hi,

There is a error is de module for the diagnostics settings and it difference from what is in the hostpool and appgroup. I did some testing and for me this is working.

resource workspace_diagnosticSettings 'Microsoft.Insights/diagnosticSettings@2021-05-01-preview' = [
  for (diagnosticSetting, index) in (diagnosticSettings ?? []): {
    name: diagnosticSetting.?name ?? '${name}-diagnosticSettings'
    properties: {
      storageAccountId: diagnosticSetting.?storageAccountResourceId
      workspaceId: diagnosticSetting.?workspaceResourceId
      eventHubAuthorizationRuleId: diagnosticSetting.?eventHubAuthorizationRuleResourceId
      eventHubName: diagnosticSetting.?eventHubName
      logs: [
        for group in (diagnosticSetting.?logCategoriesAndGroups ?? [{ categoryGroup: 'allLogs' }]): {
          categoryGroup: group.?categoryGroup
          category: group.?category
          enabled: group.?enabled ?? true
        }
      ]
      marketplacePartnerId: diagnosticSetting.?marketplacePartnerResourceId
      logAnalyticsDestinationType: diagnosticSetting.?logAnalyticsDestinationType
    }
    scope: workspace
  }
]

@moisesjgomez can you take a look at the suggetion above? I

I also ran into this issue when deploying and wanted to implement avdinsights and tested the suggestion by @jkamping too also works for me (main...john-fox-maule:bicep-registry-modules:bugfix/issue-1938l)

Hi,

There is a error is de module for the diagnostics settings and it difference from what is in the hostpool and appgroup. I did some testing and for me this is working.

resource workspace_diagnosticSettings 'Microsoft.Insights/diagnosticSettings@2021-05-01-preview' = [
for (diagnosticSetting, index) in (diagnosticSettings ?? []): {
name: diagnosticSetting.?name ?? '${name}-diagnosticSettings'
properties: {
storageAccountId: diagnosticSetting.?storageAccountResourceId
workspaceId: diagnosticSetting.?workspaceResourceId
eventHubAuthorizationRuleId: diagnosticSetting.?eventHubAuthorizationRuleResourceId
eventHubName: diagnosticSetting.?eventHubName
logs: [
for group in (diagnosticSetting.?logCategoriesAndGroups ?? [{ categoryGroup: 'allLogs' }]): {
categoryGroup: group.?categoryGroup
category: group.?category
enabled: group.?enabled ?? true
}
]
marketplacePartnerId: diagnosticSetting.?marketplacePartnerResourceId
logAnalyticsDestinationType: diagnosticSetting.?logAnalyticsDestinationType
}
scope: workspace
}
]

Wow, when seeing it in the diff it's hard to miss

On it @moisesjgomez