New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply bigdecimal scale check before converting to big int #3863

Closed

pjfanning opened this issue Apr 6, 2023 · 1 comment

Member

pjfanning commented Apr 6, 2023 •

edited

Loading

see Prevent inefficient internal conversion from BigDecimal to BigInteger wrt ultra-large scale jackson-core#968
there are 5 toBigInteger calls in jackson-databind code and it will be hard to access StreamReadConstraints (unless StreamReadConstraints,defaults() is used)
it should be safe to ignore code that takes doubles/floats and applies BigDecimal.valueOf(value).toBigInteger because the max scale of a double is 308.

The text was updated successfully, but these errors were encountered:

pjfanning mentioned this issue

validate scale before converting to BigInt #3864

Merged

Member

cowtowncoder commented Apr 6, 2023

Fixed via PR merged.

cowtowncoder closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment