-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jackson 3 TypeFactory CollectionTypes #3926
Comments
Only crossing out because this issue is against Jackson 3 not affecting the linked PR. But still +1 👍🏻 😄 |
I meant to say Jackson 3 in the issue title. I don't think there will be an appetite to change this in Jackson 2. |
Before considering those possibilities (note: they cannot be |
Looking at the quoted code, I think he meant to say "collection-like types" not "collection types". |
@yihtserns Right, that makes sense. But I think I'd prefer new "IteratorType" (or "IterableType"), since these are not (depending on one's POV, one can disagree) Collection-like -- difference between value and sort of pointer to value. |
One quick note on Same is actually true for possible new "IterationType" (or whatever name we'd use). |
Name suggestion: |
... and now that I finally read my own code comment, I realized that Old Me pointed out relevant challenge wrt add-on/tag types. So there may be reasons why there may be challenges in detecting various iterator types. But maybe it's worth trying things out and see what happens. |
Ok: realized another quick thing:
With that, I think progress can be made. This still leaves the question of |
So, support for Not sure about |
Could we consider fixing the issue described in
jackson-databind/src/main/java/tools/jackson/databind/type/TypeFactory.java
Lines 1423 to 1426 in 50b74b4
The text was updated successfully, but these errors were encountered: