Merge creator cache for Constructor and Method #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, code reviews can be challenging. Let's ask @dinomite if he could have a quick look. Changes Looks Good To Me, and since you submitted the original PR (right?) I think you can ultimately decide its safety here. |
cowtowncoder
approved these changes
Feb 17, 2023
This was referenced Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#512 added caches for each of
ConstructorandMethodwithout any particular consideration.On the other hand, it is unlikely that
Creatoris equally defined for bothConstructorandMethod, and this situation is wasteful.Therefore, these two caches were merged.
This is minor, but also mitigates the problem of #584.
@cowtowncoder
What should I do about code reviews?
I am concerned about merging complex content without review, let alone simple content like this.