Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd+p is viable for cmd bar #5427

Open
Irev-Dev opened this issue Feb 19, 2025 · 1 comment
Open

cmd+p is viable for cmd bar #5427

Irev-Dev opened this issue Feb 19, 2025 · 1 comment

Comments

@Irev-Dev
Copy link
Collaborator

We thought that this opening the browser print was baked in, in a way we couldn't get around it with js, but I think we just tried the wrong thing as

document.addEventListener('keydown', function(event) {
  if ((event.metaKey || event.ctrlKey) && event.key === 'p') {
    event.preventDefault()
    
    alert('Command palette would show here!')
  }
})

Works just fine. We could change meta k to meta p etc, or just allow custom hotkeys to be truly custom.

Relates to #5185

@pierremtb
Copy link
Collaborator

@Irev-Dev Should it be used as a yet-to-be-built file palette? And CtrlOrCmd+Shit+P as an alternative to CtrlOrCmd+K maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants