Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent changes to NewVersion regex break the "-ish" nature of the function - e.g. v24.02.05 #258

Open
galthaus opened this issue Feb 12, 2025 · 1 comment

Comments

@galthaus
Copy link

This is problematic because many versions are date allocated in dev ops use cases.

NewVersion parsed these correctly before and this change will cause large problems for our existing versions. While not in spec, it is a common usage.

Since there is already the concept of StrictNewVersion and NewVersion, it seems like a bad idea to alter NewVersion like this.

Thoughts?

@weakpixel
Copy link

Just run into a similar issue today after upgrading semver from v3.3.0 to v3.3.1

The version "0.09.00" cannot be parsed any anymore.
We have third party Helm charts which unfortunately have such a version string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants