go binary in $GOROOT should be prioritized

[FiloSottile]

Since e882fb2, the go binary in $PATH is prioritized even if go.goroot is explicitly set. It can be overridden with go.alternateTools, but it is pretty unexpected.

[FiloSottile]

Also, go.alternateTools does not expand ~, so it doesn't fully work as a replacement.

[ramya-rao-a]

Thanks for reporting @FiloSottile

Is it a common scenario to have different go binaries in $PATH vs the goroot?

[FiloSottile]

Myself I use it to develop on the standard library, and I would expect most people doing that to have different binaries in PATH. I think it's closely correlated to setting GOROOT explicitly, as that often implies using a separate toolchain.

The priority I would expect it alternateTools > GOROOT > PATH.

[ramya-rao-a]

How about other Go tools like gofmt and 3rd party Go tools

alternateTools > GOPATH > PATH > GOROOT
or
alternateTools > GOPATH > GOROOT > PATH ?

[FiloSottile]

No real reason for anything else than gofmt and go to be in GOROOT/bin, so it's almost irrelevant, but I guess "alternateTools > GOROOT > GOPATH > PATH" for consistency across all tools?

[ramya-rao-a]

I have pushed the fix to master. Can you give it a try by following the below steps and share any feedback you have.

• Download https://github.com/Microsoft/vscode-go/blob/master/Go-latest.vsix
• Run code --install-extension Go-latest.vsix
• If the above fails with Error: end of central directory record signature not found, then clone this repo and use the Go-latest.vsix file from the cloned repo
• Reload VS Code

[FiloSottile]

Thank you! ✨

[RinaFave01]

Cc creative commons

[ramya-rao-a]

The fix for this issue is now out in the latest update (0.6.85) to the Go extension.