InvalidCharacterError on document.register if $ exists in constructor function name

[gkdn]

If there is a $ character in constructor function name and constructor function is passed as the second argument to document.register, following exception is thrown:

InvalidCharacterError: The string contains invalid characters.

Following code snippet illustrates the problem:

function A$A(){}
A$A.prototype = Object.create(HTMLButtonElement.prototype);
new document.register("a-a", A$A)(); // Fails
new document.register("a-a", { prototype: A$A.prototype } )(); // Works

(Tested in Chrome 32.0.1700.41 beta - experimental Web Platform features is disabled)

[dfreedm]

The problem here is that the we're using the second argument to hold metadata. In particular, we're mapping element name to name: https://github.com/Polymer/CustomElements/blob/a2039d/src/CustomElements.js#L115, and function.name is a readonly property.

When resolving the final tag name, definition.tag is populated by defintion.name in the fallback case, and this means that new A$A will translate to document.createElement('A$A') instead of document.createElement('a-a')

[dfreedm]

Fixed by googlearchive/CustomElements@8ee223eb