Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed strip_tags() deprecated error with PHP 8.2.* #22056

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dilipbheda
Copy link
Contributor

Context

I've checked and found that the Yoast SEO plugin registers a dummy settings page with a empty title. I also reviewed the add_submenu_page function, and it appears that a title is required.

The error is triggered from this line: WordPress Core - https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/admin-header.php#L41

Summary

I think we don't need to wrap the string with a translation function since the page is registered as a dummy page.

Test instructions

  1. Navigate to the WordPress admin panel: {siteurl}/wp-admin/
  2. Click on the "Pages" menu: {siteurl}/wp-admin/edit.php?post_type=page
  3. Open the URL in any HTML validator tool or check it using the Firefox web browser.
  4. In Firefox, view the page source to see the error.
  5. With this patch, the error is not there anymore.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #22029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E_DEPRECATED: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated
2 participants