Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninitialized string offset access on invalid HPack data #8

Closed
nikic opened this issue Dec 28, 2019 · 0 comments
Closed

Uninitialized string offset access on invalid HPack data #8

nikic opened this issue Dec 28, 2019 · 0 comments

Comments

@nikic
Copy link

nikic commented Dec 28, 2019 •
edited
Loading

Doing something like (new HPack)->decode("\xff", 8192) results in an "Uninitialized string offset" warning, as decodeDynamicInteger() performs unchecked indexing.

I would expect this to yield a decoding error (null return value) instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikic