Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo for dom event handlers #3255

Merged
merged 1 commit into from
Feb 18, 2023
Merged

fix: fix typo for dom event handlers #3255

merged 1 commit into from
Feb 18, 2023

Conversation

NewByVector
Copy link
Contributor

Description

Close #3245

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #3255 (7d62649) into master (fba5310) will increase coverage by 26.45%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3255       +/-   ##
===========================================
+ Coverage   33.02%   59.48%   +26.45%     
===========================================
  Files         274       94      -180     
  Lines       17924     6365    -11559     
  Branches     3869     1324     -2545     
===========================================
- Hits         5920     3786     -2134     
+ Misses      11595     2261     -9334     
+ Partials      409      318       -91     
Flag Coverage Δ
x6 ?
x6-common 63.43% <ø> (ø)
x6-geometry 55.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/x6/src/registry/filter/util.ts
packages/x6/src/registry/highlighter/main.ts
packages/x6/src/shape/text-block.ts
packages/x6/src/registry/connection-point/util.ts
...s/x6/src/registry/router/manhattan/obstacle-map.ts
packages/x6/src/shape/base.ts
packages/x6/src/registry/registry.ts
packages/x6/src/registry/router/manhattan/util.ts
packages/x6/src/registry/attr/raw.ts
packages/x6/src/registry/marker/ellipse.ts
... and 170 more

@NewByVector NewByVector merged commit 9b4fa86 into master Feb 18, 2023
@NewByVector NewByVector deleted the fix-type branch February 18, 2023 22:28
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Feb 18, 2023
@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 18, 2023

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot x6-bot bot added the released PR has released label Feb 18, 2023
@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 24, 2023

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged PR has merged. released PR has released size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular15安装x6(2.3.0)会报错
1 participant