-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Support querying via prometheus for rocketMQ #1810
Comments
@Ceilzcx how about this, suggest use Prometheus protocol to query the rocketMQ metrics too. |
Can you briefly describe the advantages of changing to this? |
@Ceilzcx, according to apache/rocketmq#5615 (comment) and RIP-46, they have introduced new metrics in Prometheus way. See doc for detailed metrics. Besides, RIP-46, also mentioned that
|
good idea. Need to be compatible with old logic? |
I do not think it is necessary, the new method covers the metrics of the old one can query after all. |
Question
According to the doc, rocketMQ is supported for querying metrics using the Prometheus protocol. Currently the code seems to use the method of creating an instance to query information (#1046), so the metrics that could be queried seems limited and its a waste of connection resource. I think it is necessary to support querying via prometheus for rocketMQ.
btw, I'm not sure if I should create a [Task], so I just create a [Question].
The text was updated successfully, but these errors were encountered: