[Question] <Question about zookeeper monitoring>

[sppan24]

Question

存在的疑问：

1. zk的监控是基于nc命令来实现的，那为什么还会需要基于ssh协议？
2. 现在的内置zk监控模板app-zookeeper.yml，在基于ssh协议的基础上，执行的诸如echo mntr | nc 121.40.113.44 2181命令，是不正确的，如果需要监控多台zk，每个都需要改对应的ip地址，也就是说需要重新自定义监控来实现。为何不直接通过变量的形式控制即可？

我的个人考虑，是否应该直接支持nc协议，不需要over ssh会更合理一些？

[hertzbeat]

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

---

Question

Existing doubts:

1. The monitoring of zk is implemented based on the nc command, so why is it still based on the ssh protocol?
2. The current built-in zk monitoring template app-zookeeper.yml, based on the ssh protocol, executes commands such as echo mntr | nc 121.40.113.44 2181, which is incorrect. If necessary To monitor multiple zk, each needs to change the corresponding ip address, that is to say, it needs to re-customize the monitoring to achieve. Why not directly control it in the form of variables?

In my personal consideration, should the nc protocol be directly supported, and it would be more reasonable not to require over ssh?

[tomsun28]

hi 谢谢反馈 看你的分析我觉得是的👍 欢迎贡献一波直接基于 nc 来监控zookeeper 或者看 zookeeper 有没有其他类似对外接口我们可以采集数据监控

[hertzbeat]

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

---

Hi, thank you for your feedback. I think it is based on your analysis 👍 Welcome to contribute a wave of monitoring zookeeper directly based on nc or see if zookeeper has other similar external interfaces that we can collect data monitoring

[sppan24]

经过我的分析实验，zookeeper的监控完全可以基于telnet来实现和nc命令相同的效果。为了不增加系统复杂性，我扩展了项目里面的telnet协议，可以支持在telnet到指定端口后发送命令并解析响应结果。在这个基础上，可以实现zookeeper的监控，同时不需要ssh到对应的服务器上。具体实现我已经提交了PR，见 #957

[hertzbeat]

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

---

After my analysis and experiments, the monitoring of zookeeper can be based on telnet to achieve the same effect as the nc command. In order not to increase the complexity of the system, I extended the telnet protocol in the project, which can support sending commands and parsing the response results after telnet reaches the specified port. On this basis, zookeeper monitoring can be realized without ssh to the corresponding server. I have submitted PR for specific implementation, see #957

[tomsun28]

经过我的分析实验，zookeeper的监控完全可以基于telnet来实现和nc命令相同的效果。为了不增加系统复杂性，我扩展了项目里面的telnet协议，可以支持在telnet到指定端口后发送命令并解析响应结果。在这个基础上，可以实现zookeeper的监控，同时不需要ssh到对应的服务器上。具体实现我已经提交了PR，见 #957

太强了 👍