Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] <Monitoring address domain name verification logic question> #962

Closed
sppan24 opened this issue May 16, 2023 · 6 comments
Closed
Labels
question Further information is requested task

Comments

@sppan24
Copy link

sppan24 commented May 16, 2023

Question

理论上说,监控系统主要运行在内网环境,在一些企业内部,会存在内部域名。在不是很严谨的情况下,可能将一些常见字符(例如下划线)作为内部域名。这样会导致没法接入监控。我个人认为,可以考虑放开部分常见字符限制。

@sppan24 sppan24 added the question Further information is requested label May 16, 2023
@hertzbeat hertzbeat changed the title [Question] <监控地址域名校验逻辑疑问> [Question] <Monitoring address domain name verification logic question> May 16, 2023
@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Question

Theoretically speaking, the monitoring system mainly operates in the intranet environment, and in some enterprises, there will be internal domain names. In less rigorous cases, some common characters (such as underscore) may be used as internal domain names. This will result in inability to access monitoring. Personally, I think you can consider relaxing some common character restrictions.

@tomsun28
Copy link
Contributor

确实是这样 可以的👍👍 有兴趣改一波吗😄

@tomsun28 tomsun28 added the task label May 16, 2023
@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


This is indeed the case 👍👍 Are you interested in changing it? 😄

@sppan24
Copy link
Author

sppan24 commented May 17, 2023

确实是这样 可以的👍👍 有兴趣改一波吗😄

目前通过我们公司的场景来看,出现比较多的就是下划线,我已经做了兼容,详情见 #963

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


This is indeed the case 👍👍 Are you interested in changing it 😄

At present, according to the scene of our company, underscores appear more frequently. I have made compatibility, see #963 for details

@tomsun28
Copy link
Contributor

👍

@sppan24 sppan24 closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested task
Projects
None yet
Development

No branches or pull requests

3 participants