Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestBaseFileUpdatesExtractor.convertDiff is flaky #658

Open
3 of 4 tasks
ashvina opened this issue Feb 19, 2025 · 0 comments
Open
3 of 4 tasks

TestBaseFileUpdatesExtractor.convertDiff is flaky #658

ashvina opened this issue Feb 19, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ashvina
Copy link
Contributor

ashvina commented Feb 19, 2025

Search before asking

  • I had searched in the issues and found no similar issues.

Please describe the bug 🐞

The FilesDiff class does not guarantee the order of files it identifies in the add and remove sets. However, the test depends on the order and fails occasionally. Run the test suite multiple times to reproduce.

A recent build failure because of this bug is here

TestBaseFileUpdatesExtractor.convertDiff:138 expected: 
<{partition2=[file5.parquet], partition1=[file3.parquet, d1cf0980-445c-4c74-bdeb-b7e5d18779f5-0]}> 
but was: 
<{partition2=[file5.parquet], partition1=[d1cf0980-445c-4c74-bdeb-b7e5d18779f5-0, file3.parquet]}>

Are you willing to submit PR?

  • I am willing to submit a PR!
  • I am willing to submit a PR but need help getting started!

Code of Conduct

@ashvina ashvina added the bug Something isn't working label Feb 19, 2025
@ashvina ashvina self-assigned this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant