[ISSUE #9193]Optimized get sequential message lock logic #9194
+7
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9194 +/- ##
=============================================
- Coverage 48.15% 48.01% -0.14%
+ Complexity 12112 12081 -31
=============================================
Files 1321 1321
Lines 93030 93024 -6
Branches 11923 11919 -4
=============================================
- Hits 44796 44668 -128
- Misses 42715 42824 +109
- Partials 5519 5532 +13 ☔ View full report in Codecov by Sentry. |
caigy
requested changes
Feb 24, 2025
|
|
||
| LockEntry lockEntry = groupValue.get(mq); | ||
| if (null == lockEntry) { | ||
| lockEntry = new LockEntry(); | ||
| lockEntry.setClientId(clientId); | ||
| lockEntry.setLastUpdateTimestamp(System.currentTimeMillis()); |
There was a problem hiding this comment.
It seem that lastUpdateTimestamp has been initialized when LockEntry is created.
There was a problem hiding this comment.
In older versions, updatetime was not initialized here，After changing the logic, you can get the lock by default here and return success directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9193
Brief Description
How Did You Test This Change?