Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helmify] strategy.type=Recreate not supported by deployments #157

Closed
ag2308 opened this issue Nov 19, 2024 · 2 comments
Closed

[Helmify] strategy.type=Recreate not supported by deployments #157

ag2308 opened this issue Nov 19, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ag2308
Copy link
Contributor

ag2308 commented Nov 19, 2024

Helmify currently does not support the spec.strategy.type attribute for deployment YAMLs. This attribute is essential for specifying deployment strategies such as Recreate.

After looking into the code, I realized that spec.strategy.type is not supported for deployment.yaml.

Steps to Reproduce:
cd test_data
update: k8s-operator-kustomization.output, added spec.strategy.type = Recreate.
execute: cat test_data/k8s-operator-kustomization.output | go run ./cmd/helmify mychart

The generated Helm chart mychart lacks the strategy configuration in templates/deployment.yaml.

Has anyone else encountered this issue or knows of an alternative solution?

@arttor arttor added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 19, 2024
@jackspirou
Copy link

I am having the same issue. Thanks for submitting this @ag2308

@arttor
Copy link
Owner

arttor commented Dec 18, 2024

fix is available in v0.4.17 release

@arttor arttor closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants