Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add error handling #24

Open
SColson82 opened this issue Feb 17, 2025 · 1 comment · May be fixed by #25
Open

add error handling #24

SColson82 opened this issue Feb 17, 2025 · 1 comment · May be fixed by #25
Assignees
@SColson82

Comments

@SColson82
Copy link
Collaborator

According to the additions made to the SDX Provisioning document the error handling will need to be adjusted.
@SColson82 SColson82 self-assigned this Feb 17, 2025
@SColson82
Copy link
Collaborator Author

sdx_client:

  • moved http_username and password down in the init method to avoid forcing user to explicitly call name and endpoint parameters.
  • added 412 error message from the spec update into the create_l2vpn method
  • corrected the logger message in the delete method
  • corrected the repr and str method return strings

sdx_response:

  • corrected the str and eq utility methods to return a more readable format

unit tests:

  • after adjusting sdx_client and sdx_response per previous feedback (return pandas dataframe, etc) there were several unit tests that needed attention. This PR covers those and all 146 current unit tests now pass.

@SColson82 SColson82 linked a pull request Feb 19, 2025 that will close this issue
24 Add error messages from January 25 All Hands and overdue repairs on unit tests #25
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SColson82 SColson82

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@SColson82