Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: follow Deezer's format when deserializing datetime #411

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

browniebroke
Copy link
Owner

@browniebroke browniebroke commented Dec 7, 2021

  • Include tests for bug fix and new functionality
  • Updated documentation for new feature

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 7, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 0.89 ⭐ 0.83 ⭐ -0.06 👍
Method Length 30.27 ⭐ 30.33 ⭐ 0.06 👎
Working memory 4.00 ⭐ 4.03 ⭐ 0.03 👎
Quality 89.87% 89.92% 0.05% 👍
Other metrics Before After Change
Lines 786 796 10
Changed files Quality Before Quality After Quality Change
deezer/resources.py 93.24% ⭐ 92.90% ⭐ -0.34% 👎
tests/test_resources.py 88.32% ⭐ 88.60% ⭐ 0.28% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #411 (47f65bf) into main (6337967) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #411   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          485       487    +2     
  Branches        36        37    +1     
=========================================
+ Hits           485       487    +2     
Impacted Files Coverage Δ
deezer/resources.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138d317...47f65bf. Read the comment docs.

@browniebroke browniebroke merged commit 3be65e4 into main Dec 7, 2021
@browniebroke browniebroke deleted the fix/deserialize-datetime branch December 7, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant