Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Support Docker, BuildKit, img, Buildah, and Kaniko #3

Closed
gaocegege opened this issue Sep 8, 2018 · 6 comments
Closed

Comments

@gaocegege
Copy link
Contributor

Now we rely on s2i to build the image, then need to push it to a registry. As @inc0 suggested, we should investigate if knative build is better.

@gaocegege
Copy link
Contributor Author

/priority p3

@gaocegege
Copy link
Contributor Author

gaocegege commented Sep 10, 2018

Ref kubeflow/kubeflow#289

@gaocegege
Copy link
Contributor Author

img is a promising tool since it does not require docker daemon, and support pushing

@gaocegege
Copy link
Contributor Author

gaocegege commented Sep 10, 2018

kaniko also works for us since it provides docker-push as a service.

It is only supports three contexts:

  • GCS Bucket
  • S3 Bucket
  • Local

@gaocegege gaocegege changed the title [enhancement] Support Knative When Building the Images [enhancement] Support Docker, BuildKit, img, Buildah, and Kaniko Sep 25, 2018
@gaocegege
Copy link
Contributor Author

There is a benchmark for these tools: https://github.com/AkihiroSuda/buildbench

AkihiroSuda/buildbench#5

@gaocegege
Copy link
Contributor Author

I think there is no need to do it now. We should be k8s native and rely on configmaps or volumes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants