Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

probably shouldn't consider CapsLock/NumLock for ncinput_equals_p() #2555

Closed
dankamongmen opened this issue Jan 12, 2022 · 0 comments
Closed

probably shouldn't consider CapsLock/NumLock for ncinput_equals_p() #2555

dankamongmen opened this issue Jan 12, 2022 · 0 comments
Assignees
@dankamongmen
Labels
bug Something isn't working input readin' dem bytes
Milestone
3.1.0

Comments

@dankamongmen
Copy link
Owner

I don't think we care about the particular states of CapsLock when checking inputs for equality, just the result. We probably ought:

  • ensure things are capitalized when CapsLock is set
  • consider CapsLock == Shift for ncinput_equals_p()
  • ignore NumLock for ncinput_equals_p()
@dankamongmen dankamongmen added bug Something isn't working input readin' dem bytes labels Jan 12, 2022
@dankamongmen dankamongmen added this to the 3.1.0 milestone Jan 12, 2022
@dankamongmen dankamongmen self-assigned this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working input readin' dem bytes
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@dankamongmen