Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When glyph underneath us is a full block, interpret its foreground color as a background color (maybe) #801

Closed
dankamongmen opened this issue Jul 19, 2020 · 2 comments
Closed

When glyph underneath us is a full block, interpret its foreground color as a background color (maybe) #801

dankamongmen opened this issue Jul 19, 2020 · 2 comments
Assignees
@dankamongmen
Labels
enhancement New feature or request nonfix closed without a successful fix (invalid, wontfix) question/research Further information is requested
Milestone
2.0.0

Comments

@dankamongmen
Copy link
Owner

I'm not sure if this doesn't actually make things far too difficult to reason about, but I was running the demo today, and noticed that if you lay the HUD atop the FPS graph, you get black backgrounds for all HUD characters, while the spaces between them show the expected "background" (due to the foreground glyph+color coming through). See attached screenshot. In the case of a space/fullblock, maybe we invert the colors for purposes of blending? I'm unsure, but wanted to jot this down.
@dankamongmen dankamongmen added enhancement New feature or request question/research Further information is requested labels Jul 19, 2020
@dankamongmen dankamongmen added this to the 2.0.0 milestone Jul 19, 2020
@dankamongmen dankamongmen self-assigned this Jul 19, 2020
@dankamongmen
Copy link
Owner Author

This sounds interesting, but I fear it'll just be difficult to reason about and understand. Closing as a NONFIX.

@dankamongmen dankamongmen added the nonfix closed without a successful fix (invalid, wontfix) label Aug 31, 2020
@dankamongmen
Copy link
Owner Author

This idea has come back to the fore in the form of #1068.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
enhancement New feature or request nonfix closed without a successful fix (invalid, wontfix) question/research Further information is requested
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@dankamongmen