Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapsible menu at the left side #52

Open
wilzbach opened this issue May 13, 2016 · 6 comments
Open

collapsible menu at the left side #52

wilzbach opened this issue May 13, 2016 · 6 comments
Labels
Milestone

Comments

@wilzbach
Copy link
Member

this is just an idea, but I feel more structured in this way.

image

live

Optionally we make the entire menu collapse/ toggle-able.

@wilzbach wilzbach added the UI label Jun 4, 2016
@wilzbach
Copy link
Member Author

wilzbach commented Jun 4, 2016

Rust uses Git Book which also has this nice grouping:

image

http://rustbyexample.com/hello.html

@wilzbach wilzbach changed the title collapse menu at the right side collapsable menu at the left side Jun 4, 2016
@wilzbach wilzbach changed the title collapsable menu at the left side collapsible menu at the left side Jun 4, 2016
@stonemaster
Copy link
Collaborator

@wilzbach Do have any experience with vertical side bars already in other frameworks? I feel like this getting a more and more important priority with new content coming up and user input. I just would like to prevent to write the CSS etc. stuff from scratch :-)

@wilzbach
Copy link
Member Author

Unfortunately not really. Well I guess we have to throw away most parts of the dlang menu css, but apart from the mobile view, it shouldn't be that difficult.

Most css frameworks I know support such menu bar, but they come with rather heavy dependencies. However I am happy if you find something.

@PetarKirov
Copy link
Member

The previous version of dlang.org had vetical sidebar, btw.

@wilzbach
Copy link
Member Author

The previous version of dlang.org had vetical sidebar, btw.

There are a couple of pages still online with it, e.g. http://erdani.com/d/

(but of course we should go for a bit more modern menu)

@stonemaster stonemaster added this to the release-1.1 milestone Aug 13, 2016
@wilzbach
Copy link
Member Author

I just gave this a quick try and I think it will get a bit messy, because we have to hack the CSS ourselves, but it seems doable :)

Open questions:

  • mobile view (imho one of the bigger isuees))
  • show we use this change to apply make text and code box fixed height and allow scrolling #54 too (fixed height for text and code)
  • I think we need to make the menu categories collapsible (except the current one), because otherwise there's to much content
  • should the menu bar itself be toggle-able? (like for the Rust Tour)

image

quick & dirty css overwrite styles (in case someone wants to continue this attempt):

#top {
    left: 0;
    width: 250px;
    display: inline-block;
    height: 100vh;
    overflow-y: auto;
    overflow-x: hidden;
}

#top #cssmenu > ul > li {
     float: none;
}

body .row {
    display: inline-block;
    position: absolute;
}

#top #cssmenu .expand-container > * {
    display: block;
}

#top #cssmenu > ul > li > ul {
    position: inherit;
    border: none;
    background: none;
    -webkit-box-shadow: none;
    box-shadow: none;
}


#top > .helper {
     padding-left: 5px;
     padding-right: 5px;
}

#top a:hover, #top #cssmenu li.open > a, #top #cssmenu li.active > a {
     background: inherit;
}

.expand-content li {
    padding-left: 5px;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants