Review use of ArgumentException/ArgumentNullException in all public APIs

[DamianEdwards]

I noticed we seem to have lots of public APIs that accept reference type parameters not marked as nullable but then don't check that they're actually non-null and throw an ArgumentNullException when necessary. We should decide what we're doing and review all public APIs for appropriate argument validation.

e.g.

aspire/src/Aspire.Hosting/Extensions/ResourceBuilderExtensions.cs

Lines 92 to 98 in 240cde7

	public static IResourceBuilder<T> WithEnvironment<T>(this IResourceBuilder<T> builder, string name, IResourceBuilder<ParameterResource> parameter) where T : IResourceWithEnvironment
	{
	return builder.WithEnvironment(context =>
	{
	context.EnvironmentVariables[name] = parameter.Resource;
	});
	}

[mitchdenny]

@JamesNK your PR mentioned this issue, do you think we've got 100% coverage here now from your #2809 PR?

[JamesNK]

Probably not. And there have been new APIs since then.

[mitchdenny]

There are a few outstanding PRs with this but then I think we can probably call this issue substantially done (at least enough for now). Thanks to @Zombach, @bell-nat and @Alirexaa for their efforts here!

@DamianEdwards ?