Remove InternalsVisibleTo from Aspire.Hosting to Aspire.Hosting.Testing

[eerhardt]

Today we have InternalsVisibleTo from Aspire.Hosting to Aspire.Hosting.Testing

aspire/src/Aspire.Hosting/Aspire.Hosting.csproj

Line 59 in 9073e07

<InternalsVisibleTo Include="Aspire.Hosting.Testing" />

We need to remove this because we aren't guaranteed that these 2 nuget packages version in lock step, or that users will always have the exact same matching versions (they could upgrade their Aspire.Hosting without updating the Aspire.Hosting.Testing). When this happens, and we refactor some internal APIs, users will get weird errors above types/methods not existing.

cc @davidfowl @ReubenBond @mitchdenny

[mitchdenny]

I would have thought that they would go together.

[davidfowl]

Still we should not couple their internals like this. We should expose the appropriate APIs.

[eerhardt]

I would have thought that they would go together.

Since they ship as separate NuGet packages, you can't guarantee this. Imagine you pull in some reference like Aspire.Hosting.Azure or Aspire.Hosting.MongoDB and it lifts your version of Aspire.Hosting to a new version. Now your tests start breaking because you have a different version of Aspire.Hosting and Aspire.Hosting.Testing.