Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Traces & Log messages - viewer for long fields #4412

Closed
samsp-msft opened this issue Jun 6, 2024 · 8 comments · Fixed by #5018
Closed

Dashboard: Traces & Log messages - viewer for long fields #4412

samsp-msft opened this issue Jun 6, 2024 · 8 comments · Fixed by #5018

Comments

@samsp-msft
Copy link
Member

samsp-msft commented Jun 6, 2024

There is an initiative to use OTel to provide telemetry for LLM applications - recording the prompt and response text. These are typically long and can be plain text or json. When looking at these in the Aspire dashboard, in the trace and logs view, the details pane has a one line display with a "..." and button to copy to the dashboard.

image

Visual Studio debugger has the same problem when its showing variables in the watch window. It has an option to pop out the value in a modal dialog, where text can be more easily examined. We should have something similar for the dashboard.

image

image

When the text is opened in the viewer, we should have a quick mechanism to sniff to see if it looks to be json, and then provide an option to format the content as json - as it typically will not have any formatting. The VS one has the ability to do base64, url encoding/decoding. Those are probably not needed here, but JSON and possibly XML formatting would be very useful.
If it fails to parse that would also be really useful to know, so spitting out the error in those cases would be good.

@davidfowl davidfowl added this to the 8.1 milestone Jun 7, 2024
@davidfowl
Copy link
Member

This feels very important. Makes the dashboard a bit unusable with large text values.

@samsp-msft
Copy link
Member Author

I am thinking something like:
image

@leslierichardson95
Copy link

TODO: Figure out an owner here.

@kvenkatrajan kvenkatrajan modified the milestones: 8.1, 8.2 Jun 11, 2024
@samsp-msft
Copy link
Member Author

samsp-msft commented Jun 12, 2024

This will also be needed for events on spans in the trace details view, as those will also have the same long messages attached.
image

@adamint
Copy link
Member

adamint commented Jun 19, 2024

@kvenkatrajan for assignment.

@adamint
Copy link
Member

adamint commented Jul 16, 2024

I am thinking something like: image

@samsp-msft we already have a button there for copying the grid value. We could replace with a button that opens a little tooltip where you can choose your action? Or we could put both buttons inline.

@adamint
Copy link
Member

adamint commented Jul 17, 2024

As per discussion with @leslierichardson95 and @samsp-msft, we would like to have a button to open a menu, where you will be able to choose whether to open this popup or copy the cell text.

@davidfowl
Copy link
Member

Sweet!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants