-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose health check status in the dashboard #5569
Comments
In the dashboard we can show them as another section in the Resource Details view, along with properties, endpoints and env vars. I assume we won't need the ability to mask these values. They don't seem like sensitive information. |
cc @leslierichardson95 this is part of the 9.0 work. |
Next steps: Agree on what the UI will be and what the contract is between App Model and Dashboard. This is part of the WaitFor story. |
I've done the first bullet (which I think is the min bar for 9). We can attempt to design the health checks panel or expand the existing details view to add health checks there. Thoughts? |
I'm working on showing these in the details area. If there's a description or exception, they'll be displayed. I haven't seen an example of either in practice though, so am not sure what formatting they might need. For example, should the exception be displayed in monospace, preformatted? While here I've also added details about "Waits For":
We don't currently have a way to navigate to a section in the details pane. We could collapse all other sections and force the details view to be open. |
For the exception we'll probably want to be able to bring it up in its own window like we can with some of the other values in the dashboard (although it is fine to get to that via the panel here). People will probably want it to be preformatted text (see how it looks?). |
When I say people ... I'm using my sample size of one :) |
In #5515 we are introducing health checks into resources so that when
WaitFor
is used and a health check is associated with a resource it blocks dependent resources from starting up until the check enters either a terminal state or is healthy.We want to light up this feature in the dashboard so that developers can reason why a particular resource is not healthy. The key features are:
Running (Healthy)
orRunning (Unhealthy)
. If the resource does not have any health checks associated with it then the health status can be ommitted.Unhealthy
should be a hyperlink that brings up the resource details panel and displays the health checks section.The text was updated successfully, but these errors were encountered: