-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review the UX experience in dashboard for cases where having a launchUrl different to the app/endpoint url is required. #917
Comments
@maryamariyan - If I understand correctly, in the sample here echobot is a bot which is installed in teams already so you want to start serving the bot on specified URL but want to launch teams.microsoft.com to test out the bot. Is that correct? |
Chatted offline with @smitpatel. Using the solution in Azure-Samples/openai, tried placing two replicas for the teams app: builder.AddProject<Projects.TeamsApp>("teamsapp")
.WithReference(apiservice)
+ .WithReplicas(2); and we investigated how load balancing is done and confirmed both replicas may end up getting used: |
Here is the summary of discussion I had with @maryamariyan We have few options to show for endpoint when applicationUrl and launchUrl are diverging
If we add a summary row for replica set (to group replicas of same project together), we can show launchUrl for replica set and individual replicas will still follow above set. We need to decide what we want to show in UI. Tagging folks for thoughts - @leslierichardson95 @tlmii @davidfowl @DamianEdwards |
Related to #567 |
This is what I'd expect I think. |
@smitpatel I also like the idea of adding a summary row for the replica set too since that seems like the clearest, most transparent option. |
@DamianEdwards, @tlmii, and @smitpatel, as a possible idea for addressing the replica grouping situation overall, can we maybe adopt a tree view experience in the different tables, where the user can expand a row to view all the replicas and their respective information (see attached, sketchy image)? |
I think that's a fairly ideal display but our current DataGrid component does not support it directly. So we'd need to evaluate our options (add support to the underlying grid? Roll our own grid? Hack it together on top of the existing grid?) to see how it could be accomplished. |
Grid nesting for the win. |
cc @mitchdenny |
@davidfowl did you tag me because adding replicas results in the data not showing up on the dashboard correctly? |
I wanted to re-test this scenario with the preview3 logic. |
@maryamariyan where is the app you were testing? |
Here is the app: I'll take a look and let you know how it reproduces |
Testing again today. Given
I see dashboard: It is not what I expected because in the teams app case, |
@drewnoakes and @mitchdenny This is a dashboard/api problem. We need to split the endpoint from the display URL in the API (if that doesn't already exist). |
Maybe we can kill two birds with one stone here. I've been wanting to be able to annotate resources with a URI/callback mechanism that could be invoked from the dashboard. We could start with a URI. Then, for resources where we detect a launchUrl in the launch profile we can append that annotation. This same bit of UX would be used for commanding such as restarting services etc when we get there. |
This doesn't feel like commanding (which has implications on auth). This feels like data. |
@maryamariyan This will be easier to do after my changes. Would you be interested in sending a PR for this still? |
Closing this issue since most of these changes have since been added to the dashboard, including easy replica identification listings. |
Existing use case:
For example, check out this echo-bot sample on microsoft/teams-ai
launchSettings.json
, the launchUrl and applicationUrl are not related.Consideration:
launchUrl
in the dashboard, is there already a good way to dynamically pick up (get) thelaunchUrl
value and use it in (for example) in the webfrontend project?For more details, refer back to #812 (comment)
The text was updated successfully, but these errors were encountered: