Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out whether project system should be using ConfigureAwait(true/false) on its await calls #6770

Closed
davkean opened this issue Nov 13, 2015 · 2 comments
Closed

Figure out whether project system should be using ConfigureAwait(true/false) on its await calls #6770

davkean opened this issue Nov 13, 2015 · 2 comments
Assignees
@davkean
Labels
0 - Backlog help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
2.0 (Preview 5)

Comments

@davkean
Copy link
Member

davkean commented Nov 13, 2015

We've currently suppress all usages of RS0003 in the project system code:

Warning RS0003  Do not directly await a Task without calling ConfigureAwait

We should review all instances of the suppressed values and figure out if we want ConfigureAwait(true) or ConfigureAwait(false).
@davkean
Copy link
Member Author

davkean commented Nov 13, 2015

Search for this bug number to find the instances.

@davkean davkean mentioned this issue Nov 13, 2015
Merged
3 tasks
@Pilchie Pilchie added this to the 2.0 milestone Nov 17, 2015
@DustinCampbell DustinCampbell modified the milestones: 2.0 (RC), 2.0 (Preview) Mar 9, 2016
@davkean davkean added Area-Project System help wanted The issue is "up for grabs" - add a comment if you are interested in working on it and removed Area-IDE labels Apr 29, 2016
@davkean
Copy link
Member Author

davkean commented May 13, 2016

This issue was moved to dotnet/project-system#124

@davkean davkean mentioned this issue May 13, 2016
Closed
@davkean davkean closed this as completed May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davkean davkean

Labels
0 - Backlog help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Milestone
2.0 (Preview 5)
Development

No branches or pull requests
3 participants
@DustinCampbell @Pilchie @davkean