Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details #12

Open
tangrammer opened this issue Apr 6, 2020 · 2 comments

Comments

@tangrammer
Copy link

Hi @finnfiddle :)

We've updated react to last version on akvo-lumen client and now we get this problem that I'd bet that comes from your lib 🤔

  • Move code with side effects to componentDidMount, and set initial state in the constructor.
  • Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: _class

...
Please update the following components: Text

I tried to run npx react-codemod rename-unsafe-lifecycles in your lib but the results are weird 😬

any ideas??

have a good day!

@finnfiddle
Copy link
Owner

Hi @tangrammer nice to hear from you. Thanks for reporting Ill take a look into it

@finnfiddle
Copy link
Owner

hey I looked into it but couldnt reproduce. Please could you provide a reproducible example/repo and I will sort it out. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants