Import/Export - Fix 'entity values are mixed' exception when no valid data #32904

fredden · 2021-04-29T15:53:02Z

Description

The Import/Export module can operate in two modes: skip errors, stop on error. When configured to skip errors, the import will proceed irrespective of the validation result. When there is no data to import, a exception "entity values are mixed" is thrown. This pull request solves the problem by failing validation in this case.

Related Pull Requests

Fixed Issues

Fixes Error in data structure: entity values are mixed firegento/FireGento_FastSimpleImport2#109
Fixes [Issue] Import/Export - Fix 'entity values are mixed' exception when no valid data #32905

Manual testing scenarios

Create an import file with only invalid data (eg, SKUs that don't exist, invalid customer address fields, malformed customer email addresses)
Configure the Magento importer to skip validation errors
Import the file
Without this pull request: validation passes, but the import fails with a message that "entity values are mixed"
With this pull request: validation fails with a message saying that "There are no valid rows to import."

Questions or comments

none

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Import/Export - Fix 'entity values are mixed' exception when no valid data #32905: Import/Export - Fix 'entity values are mixed' exception when no valid data

m2-assistant · 2021-04-29T15:53:05Z

Hi @fredden. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

magento-automated-testing · 2021-04-29T16:04:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

gabrieldagama · 2021-04-29T16:09:47Z

@magento create issue

…t/entity-values-are-mixed

magento-automated-testing · 2021-05-05T21:33:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev

Please check failing integration tests

Den4ik

Hi @fredden! Thanks for your contribution.
I believe that extending of isErrorLimitExceeded for both situations: skip or stop on errors is better solution.

…t/entity-values-are-mixed

fredden · 2021-05-09T13:50:27Z

I believe that extending of isErrorLimitExceeded for both situations: skip or stop on errors is better solution.

@Den4ik the ProcessingErrorAggregator (where isErrorLimitExceeded() is found) does not appear to have access to the total row count. How do you suggest this information should be obtained?

engcom-Lima · 2023-07-06T09:28:04Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop and PHP 8.1

*Manual testing scenario:

Create an import file with only invalid data (eg, SKUs that don't exist, invalid customer address fields, malformed customer email addresses)
Configure the Magento importer to skip validation errors
Import the file

Before: ✖️ Import button was displayed.

Getting error after importing "Additional data:Error in data structure: entity values are mixed":

After: ✔️ Now working fine.
Import button disappeared because of invalid data

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Echo · 2023-07-10T02:25:08Z

@magento run Integration Tests, Functional Tests EE,Functional Tests CE,Functional Tests B2B

magento-automated-testing · 2023-07-10T02:25:15Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-07-10T04:14:14Z

@magento run Integration Tests

magento-automated-testing · 2023-07-10T04:14:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing · 2023-07-10T06:09:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-07-10T08:00:12Z

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

magento-automated-testing · 2023-07-10T08:00:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-07-10T12:13:22Z

Integration Tests failure is not related to PR.
Functional Tests CE, Functional Tests EE, Functional Tests B2B failures are different on last two run on same commit.
Functional Tests CE
Run1

Run2

Functional Tests EE
Run1

Run2

Functional Tests B2B
Run1

Run2

Hence moving it to Merge In Progress

Fix 'entity values are mixed' exception

0762e09

magento-engcom-team added Component: ImportExport Release Line: 2.4 Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Apr 29, 2021

gabrieldagama added the Priority: P3 May be fixed according to the position in the backlog. label Apr 29, 2021

m2-community-project bot added the Progress: pending review label Apr 29, 2021

m2-assistant bot mentioned this pull request Apr 29, 2021

[Issue] Import/Export - Fix 'entity values are mixed' exception when no valid data #32905

Closed

5 tasks

fredden added 2 commits May 5, 2021 22:17

Merge remote-tracking branch 'upstream/2.4-develop' into import-expor…

3974fe8

…t/entity-values-are-mixed

Fix unit test

9237592

ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels May 7, 2021

ihor-sviziev self-assigned this May 7, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels May 7, 2021

ihor-sviziev requested changes May 7, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels May 7, 2021

Den4ik requested changes May 7, 2021

View reviewed changes

m2-community-project bot assigned Den4ik May 7, 2021

Merge remote-tracking branch 'upstream/2.4-develop' into import-expor…

90d6afc

…t/entity-values-are-mixed

engcom-Lima added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Jul 6, 2023

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Jul 6, 2023

m2-community-project bot added Progress: extended testing and removed Progress: ready for testing labels Jul 6, 2023

Merge branch '2.4-develop' into import-export/entity-values-are-mixed

9825ce3

engcom-Echo self-assigned this Jul 10, 2023

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing labels Jul 10, 2023

m2-community-project bot added Progress: extended testing and removed Progress: ready for testing labels Jul 10, 2023

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jul 10, 2023

magento-devops-reposync-svc merged commit a413707 into magento:2.4-develop Aug 31, 2023

fredden deleted the import-export/entity-values-are-mixed branch August 31, 2023 12:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import/Export - Fix 'entity values are mixed' exception when no valid data #32904

Import/Export - Fix 'entity values are mixed' exception when no valid data #32904

fredden commented Apr 29, 2021 •

edited

Loading

m2-assistant bot commented Apr 29, 2021

magento-automated-testing bot commented Apr 29, 2021

gabrieldagama commented Apr 29, 2021

magento-automated-testing bot commented May 5, 2021

ihor-sviziev left a comment

Den4ik left a comment •

edited

Loading

fredden commented May 9, 2021

engcom-Lima commented Jul 6, 2023

engcom-Echo commented Jul 10, 2023

magento-automated-testing bot commented Jul 10, 2023

engcom-Echo commented Jul 10, 2023

magento-automated-testing bot commented Jul 10, 2023

magento-automated-testing bot commented Jul 10, 2023

engcom-Echo commented Jul 10, 2023

magento-automated-testing bot commented Jul 10, 2023

engcom-Echo commented Jul 10, 2023

Import/Export - Fix 'entity values are mixed' exception when no valid data #32904

Import/Export - Fix 'entity values are mixed' exception when no valid data #32904

Conversation

fredden commented Apr 29, 2021 • edited Loading

Description

Related Pull Requests

Fixed Issues

Manual testing scenarios

Questions or comments

Contribution checklist

Resolved issues:

m2-assistant bot commented Apr 29, 2021

magento-automated-testing bot commented Apr 29, 2021

gabrieldagama commented Apr 29, 2021

magento-automated-testing bot commented May 5, 2021

ihor-sviziev left a comment

Choose a reason for hiding this comment

Den4ik left a comment • edited Loading

Choose a reason for hiding this comment

fredden commented May 9, 2021

engcom-Lima commented Jul 6, 2023

✔️ QA Passed

engcom-Echo commented Jul 10, 2023

magento-automated-testing bot commented Jul 10, 2023

engcom-Echo commented Jul 10, 2023

magento-automated-testing bot commented Jul 10, 2023

magento-automated-testing bot commented Jul 10, 2023

engcom-Echo commented Jul 10, 2023

magento-automated-testing bot commented Jul 10, 2023

engcom-Echo commented Jul 10, 2023

fredden commented Apr 29, 2021 •

edited

Loading

Den4ik left a comment •

edited

Loading