Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Allow dep ensure -add and -update when lock is out-of-sync #1126

Closed
ibrasho opened this issue Sep 5, 2017 · 6 comments · Fixed by #1225
Closed

Allow dep ensure -add and -update when lock is out-of-sync #1126

ibrasho opened this issue Sep 5, 2017 · 6 comments · Fixed by #1225

Comments

@ibrasho
Copy link
Collaborator

ibrasho commented Sep 5, 2017

#1109 changed the error message printed when the lock file is out-of-sync with the manifest and the project's imports.

This error seems a bit strict and we want to allow the user to use dep ensure -add and dep ensure -update even when things are out-of-sync. The error should be printed as a warning instead, but execution should resume.

The changes should happen to the same files modified in #1109.

@ibrasho
Copy link
Collaborator Author

ibrasho commented Sep 5, 2017

cc: @akutz

@7373Lacym
Copy link

I would like to work on this if possible.

@ibrasho
Copy link
Collaborator Author

ibrasho commented Sep 8, 2017

Go for it. 👍

Let me know if you need any pointers.

@sdboyer
Copy link
Member

sdboyer commented Sep 18, 2017

@7373Lacym it's been near two weeks - are you still planning on working on this? it's fine if not, but it'd be ideal if you could update this issue if you don't have time, so that other folks feel comfortable claiming it.

@miguel250
Copy link
Contributor

@carolynvs mentioned that this was up for grabs so I am taking it.

@7373Lacym
Copy link

👍 Sounds good. Im not able to get to this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants