Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Name validity should not be checked when the Source path is provided #1159

Closed
illotum opened this issue Sep 11, 2017 · 1 comment
Closed

Comments

@illotum
Copy link

illotum commented Sep 11, 2017

For various reasons, a team may choose to mask its repo path under a different name:

> cat Gopkg.toml
[[constraint]]
  name = "company.com/package"
  source = "https://git.domain.com/path/package.git"
  version = "0.3.1"

This should not lead to dep failing.

What version of dep are you using (dep version)?

v0.3.0-295-gbeb6bb1

What dep command did you run?

> dep ensure -v
The following issues were found in Gopkg.toml:

  ✗ unable to deduce repository and source type for "company.com/package": unable to read metadata: go-import metadata not found

ProjectRoot name validation failed

What did you expect to see?

I expected dep to match "source" to all imports under "name", but not check "name" for validity.

What did you see instead?

dep ensure failed when the "name" path was found to be undiscoverable.

@sdboyer
Copy link
Member

sdboyer commented Sep 11, 2017

hi! i appreciate the issue. unfortunately, there's more to this one than it may seem. have a look at #860, where we have some more discussion on the challenges with this. it's not impossible, but it's not easy, either.

(closing as dup)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants