Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Support a glob syntax for ignored in Gopkg.toml #691

Closed
timtadh opened this issue May 31, 2017 · 3 comments · Fixed by #1156
Closed

Support a glob syntax for ignored in Gopkg.toml #691

timtadh opened this issue May 31, 2017 · 3 comments · Fixed by #1156

Comments

@timtadh
Copy link

timtadh commented May 31, 2017

I have a research project that has an "examples" directory which has a whole GOPATH inside of it. The research project is a static/dynamic analysis project so the examples directory are example programs. This directory has its own system for managing dependencies outside of the one for the main code base. Right now I have to specify each individual directory inside of my Gopkg.toml to get dep to ignore the examples. I want to say:

ignored = ["path/blah/project/examples/..."]

but currently i say

ignored = ["path/blah/project/examples", 
                 "path/blah/project/examples/src",
                 "path/blah/project/examples/src/foo",
                 "path/blah/project/examples/src/bar", 
                 ...]
@sdboyer
Copy link
Member

sdboyer commented Jun 5, 2017

Yeah this is super annoying to have to do. I had an issue long ago, sdboyer/gps#88 about doing this (or an equivalent), but never got around to it. I don't think my worries about solver guarantees (which is why I thought it might not be a good idea) hold any water.

@kron4eg
Copy link

kron4eg commented Jul 13, 2017

Yeah this is super annoying to have to do.

+1, just now had to do this:

$ git diff Gopkg.toml
diff --git a/Gopkg.toml b/Gopkg.toml
index 5f7dbcb..6736737 100644
--- a/Gopkg.toml
+++ b/Gopkg.toml
@@ -5,6 +5,11 @@ required = [
 ignored = [
     "golang.org/x/sys/windows",             # go-nats want this
+    "golang.org/x/sys/windows/registry",    # go-nats want this
+    "golang.org/x/sys/windows/svc",         # go-nats want this
+    "golang.org/x/sys/windows/svc/debug",   # go-nats want this
+    "golang.org/x/sys/windows/svc/eventlog",# go-nats want this
+    "golang.org/x/sys/windows/svc/mgr",     # go-nats want this
     "golang.org/x/crypto/bcrypt",           # go-nats want this
     "golang.org/x/crypto/ssh/terminal",     # go-nats want this
 ]
@@ -31,7 +36,7 @@ branch = "master"

Instead of just "golang.org/x/sys/windows/..."

@xiaopengli89
Copy link

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants