Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: Pow10 freeze the compiler on certain condition on Go 1.24 [1.24 backport] #71855

Open
gopherbot opened this issue Feb 20, 2025 · 1 comment
Labels
CherryPickCandidate Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone

Comments

@gopherbot
Copy link
Contributor

@Jorropo requested issue #71852 to be considered for backport to the next 1.24 minor release.

@gopherbot Please open backport issue for 1.24

This is a regression where non esoteric code that used to build now does not.
https://gophers.slack.com/archives/C6CM8NUEB/p1740060033459149

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 20, 2025
@Jorropo Jorropo added this to the Go1.24.1 milestone Feb 20, 2025
@Jorropo
Copy link
Member

Jorropo commented Feb 20, 2025

I've submitted two different proper fixes:

We merged the simple 2 sloc fix.

My original plan to revert 820f58a would not solve all regression cases, just the particular one discovered in #71852.

~~I think the only correct revert would involve reverting most of @randall77's prove constants handling improvements, so I think we should consider backporting the fix altho this is more risky~~ edit: the previous implementation has known bugs that were fixed in this refactor like #67625. I don't think that relevant to bring this up anymore.
If rather than backporting, we could revert 3b96eeb which would be very messy and require reverting more commits than I have fingers.

@Jorropo Jorropo changed the title math: Pow10 freeze the compiler on certain condition on Go 1.24 [1.24 backport] cmd/compile: Pow10 freeze the compiler on certain condition on Go 1.24 [1.24 backport] Feb 20, 2025
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickCandidate Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Development

No branches or pull requests

2 participants