Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig: update to target es2022 #3540

Closed
hyangah opened this issue Sep 17, 2024 · 1 comment
Closed

tsconfig: update to target es2022 #3540

hyangah opened this issue Sep 17, 2024 · 1 comment
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 17, 2024

During the review of https://go.dev/cls/606695

@firelizzard18 pointed out:

For reference, this repository lists each vscode version and what version of electron it uses and what version of node that uses: https://github.com/ewanharris/vscode-versions. And this website lists which ES20xx features are supported by which versions of node: https://node.green/. vscode-go currently supports vscode 1.75.0 and earlier, which means it must be able to support node 16.14.2 and later.

node.green shows that 16.14.2 supports almost the entirety of ES2018 (it's only missing escapes for unicode 14+), so we're good there.

It appears that 16.14.2 also supports up through ES2022 (except for one new RegExp flag does not appear in the flags property). So maybe we should update to ES2022 instead?

I think that's a valid point.
https://compat-table.github.io/compat-table/es2016plus/ also shows mostly green for recent versions of major browsers too.

@hyangah hyangah added this to the v0.44.0 milestone Sep 17, 2024
@gopherbot gopherbot modified the milestones: v0.44.0, Untriaged Sep 17, 2024
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/606695 mentions this issue: extension/tsconfig.json: target es2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants