Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode keeps reconnecting with golang.go-0.16.0 #467

Closed
ivensli opened this issue Aug 4, 2020 · 10 comments
Closed

vscode keeps reconnecting with golang.go-0.16.0 #467

ivensli opened this issue Aug 4, 2020 · 10 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
v0.16.1

Comments

@ivensli
Copy link

ivensli commented Aug 4, 2020

after update to golang.go-0.16.0, vscode keep reconnecting to remote.
[2020-08-04 14:46:17.238] [remoteagent] [info] [127.0.0.1][c4fe4ed8][ExtensionHostConnection] <10780> Extension Host Process exited with code: 7, signal: null.
[2020-08-04 14:46:17.239] [remoteagent] [info] Cancelling previous shutdown timeout
@bmharper
Copy link

bmharper commented Aug 4, 2020

The following procedure fixed this issue for me:

  1. Uninstall VSCode Go extension
  2. Update system Go from 1.13 to 1.14
  3. Reinstall VSCode Go extension

@hyangah
Copy link
Contributor

hyangah commented Aug 4, 2020

@ivensli @bmharper Thanks for the report. We need more info to reproduce the problem.

  • Involved OSes.
  • Go versions.
  • Any other logs in OUTPUT channels?
    Log (Remote Server), Log (Remote Extension Host), Go

@hyangah hyangah added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 4, 2020
@SteveHNH
Copy link

SteveHNH commented Aug 5, 2020 •
edited
Loading

@hyangah
I'm experiencing the same issue since the update to the 0.16.0 version. When I'm in a remote SSH session, inside a golang project, my connection drops after about 10 seconds. If I don't open a Go project, I can stay connected. If I uninstall this extension, I can also stay connected.

Hopefully some of this info helps. Let me know if you need more.

OSes
Remote: Fedora 30
Source: Windows 10

Go version 1.14.6

Remote Extension Host Log

[2020-08-04 21:26:08.989] [exthost] [info] ExtensionService#_doActivateExtension vscode.debug-auto-launch {"startup":true,"extensionId":{"value":"vscode.debug-auto-launch","_lower":"vscode.debug-auto-launch"},"activationEvent":"*"}
[2020-08-04 21:26:08.990] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/bin/91899dcef7b8110878ea59626991a18c8a6a1b3e/extensions/debug-auto-launch/dist/extension
[2020-08-04 21:26:08.996] [exthost] [info] ExtensionService#_doActivateExtension vscode.emmet {"startup":true,"extensionId":{"value":"vscode.emmet","_lower":"vscode.emmet"},"activationEvent":"*"}
[2020-08-04 21:26:08.996] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/bin/91899dcef7b8110878ea59626991a18c8a6a1b3e/extensions/emmet/dist/extension
[2020-08-04 21:26:09.011] [exthost] [info] ExtensionService#_doActivateExtension vscode.git {"startup":true,"extensionId":{"value":"vscode.github","_lower":"vscode.github"},"activationEvent":"*"}
[2020-08-04 21:26:09.011] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/bin/91899dcef7b8110878ea59626991a18c8a6a1b3e/extensions/git/dist/main
[2020-08-04 21:26:09.040] [exthost] [info] ExtensionService#_doActivateExtension vscode.github-authentication {"startup":true,"extensionId":{"value":"vscode.github-authentication","_lower":"vscode.github-authentication"},"activationEvent":"*"}
[2020-08-04 21:26:09.040] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/bin/91899dcef7b8110878ea59626991a18c8a6a1b3e/extensions/github-authentication/dist/extension.js
[2020-08-04 21:26:09.048] [exthost] [info] ExtensionService#_doActivateExtension vscode.merge-conflict {"startup":true,"extensionId":{"value":"vscode.merge-conflict","_lower":"vscode.merge-conflict"},"activationEvent":"*"}
[2020-08-04 21:26:09.048] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/bin/91899dcef7b8110878ea59626991a18c8a6a1b3e/extensions/merge-conflict/dist/mergeConflictMain
[2020-08-04 21:26:09.050] [exthost] [info] ExtensionService#_doActivateExtension vscode.microsoft-authentication {"startup":true,"extensionId":{"value":"vscode.microsoft-authentication","_lower":"vscode.microsoft-authentication"},"activationEvent":"*"}
[2020-08-04 21:26:09.050] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/bin/91899dcef7b8110878ea59626991a18c8a6a1b3e/extensions/microsoft-authentication/dist/extension.js
[2020-08-04 21:26:09.057] [exthost] [info] ExtensionService#_doActivateExtension vscode.search-result {"startup":true,"extensionId":{"value":"vscode.search-result","_lower":"vscode.search-result"},"activationEvent":"*"}
[2020-08-04 21:26:09.057] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/bin/91899dcef7b8110878ea59626991a18c8a6a1b3e/extensions/search-result/dist/extension.js
[2020-08-04 21:26:09.058] [exthost] [info] ExtensionService#_doActivateExtension donjayamanne.githistory {"startup":true,"extensionId":{"value":"donjayamanne.githistory","_lower":"donjayamanne.githistory"},"activationEvent":"*"}
[2020-08-04 21:26:09.058] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/extensions/donjayamanne.githistory-0.6.9/dist/src/extension
[2020-08-04 21:26:09.090] [exthost] [info] ExtensionService#_doActivateExtension eamodio.gitlens {"startup":true,"extensionId":{"value":"eamodio.gitlens","_lower":"eamodio.gitlens"},"activationEvent":"*"}
[2020-08-04 21:26:09.090] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/extensions/eamodio.gitlens-10.2.2/dist/extension
[2020-08-04 21:26:09.145] [exthost] [info] ExtensionService#_doActivateExtension fabiospampinato.vscode-todo-plus {"startup":true,"extensionId":{"value":"fabiospampinato.vscode-todo-plus","_lower":"fabiospampinato.vscode-todo-plus"},"activationEvent":"*"}
[2020-08-04 21:26:09.145] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/extensions/fabiospampinato.vscode-todo-plus-4.17.1/out/extension.js
[2020-08-04 21:26:09.179] [exthost] [info] ExtensionService#_doActivateExtension karigari.chat {"startup":true,"extensionId":{"value":"karigari.chat","_lower":"karigari.chat"},"activationEvent":"*"}
[2020-08-04 21:26:09.179] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/extensions/karigari.chat-0.35.0/out/extension
[2020-08-04 21:26:09.256] [exthost] [info] ExtensionService#_doActivateExtension ms-vsliveshare.vsliveshare {"startup":true,"extensionId":{"value":"ms-vsliveshare.vsliveshare-audio","_lower":"ms-vsliveshare.vsliveshare-audio"},"activationEvent":"*"}
[2020-08-04 21:26:09.256] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/extensions/ms-vsliveshare.vsliveshare-1.0.2478/out/prod/extension-prod
[2020-08-04 21:26:09.484] [exthost] [info] Extension 'fabiospampinato.vscode-todo-plus' uses a document selector without scheme. Learn more about this: https://go.microsoft.com/fwlink/?linkid=872305
[2020-08-04 21:26:09.539] [exthost] [info] ExtensionService#_doActivateExtension golang.go {"startup":true,"extensionId":{"value":"golang.go","_lower":"golang.go"},"activationEvent":"workspaceContains:**/*.go"}
[2020-08-04 21:26:09.539] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/extensions/golang.go-0.16.0/dist/goMain.js
[2020-08-04 21:26:09.778] [exthost] [info] Extension 'golang.go' uses a document selector without scheme. Learn more about this: https://go.microsoft.com/fwlink/?linkid=872305
[2020-08-04 21:26:09.936] [exthost] [warning] [Deprecation Warning] 'window.registerTaskProvider' is deprecated. Use the corresponding function on the 'tasks' namespace instead
[2020-08-04 21:26:09.986] [exthost] [info] Extension 'ms-vsliveshare.vsliveshare' uses a document selector without scheme. Learn more about this: https://go.microsoft.com/fwlink/?linkid=872305
[2020-08-04 21:26:09.987] [exthost] [info] ExtensionService#_doActivateExtension vscode.github {"startup":true,"extensionId":{"value":"vscode.github","_lower":"vscode.github"},"activationEvent":"*"}
[2020-08-04 21:26:09.987] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/bin/91899dcef7b8110878ea59626991a18c8a6a1b3e/extensions/github/dist/extension.js
[2020-08-04 21:26:10.000] [exthost] [info] ExtensionService#_doActivateExtension ms-vsliveshare.vsliveshare-audio {"startup":true,"extensionId":{"value":"ms-vsliveshare.vsliveshare-audio","_lower":"ms-vsliveshare.vsliveshare-audio"},"activationEvent":"*"}
[2020-08-04 21:26:10.000] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/sadams/.vscode-server/extensions/ms-vsliveshare.vsliveshare-audio-0.1.85/out/extension
[2020-08-04 21:26:10.790] [exthost] [info] eager extensions activated

Remote Server

[2020-08-04 21:27:41.385] [remoteagent] [info] Got delay-shutdown request while in shutdown timeout, delaying
[2020-08-04 21:27:41.385] [remoteagent] [info] Cancelling previous shutdown timeout
[2020-08-04 21:27:41.439] [remoteagent] [info] [127.0.0.1][3775a6dc][ManagementConnection] New connection established.
[2020-08-04 21:27:41.441] [remoteagent] [info] [127.0.0.1][022ce40e][ExtensionHostConnection] New connection established.
[2020-08-04 21:27:41.452] [remoteagent] [info] [127.0.0.1][022ce40e][ExtensionHostConnection] <13369> Launched Extension Host Process.
[2020-08-04 21:27:45.137] [remoteagent] [info] [127.0.0.1][58cb3e67][ExtensionHostConnection] <13191> Extension Host Process exited with code: 0, signal: null.
[2020-08-04 21:27:45.138] [remoteagent] [info] Cancelling previous shutdown timeout
[2020-08-04 21:27:48.156] [remoteagent] [info] [127.0.0.1][022ce40e][ExtensionHostConnection] <13369> Extension Host Process exited with code: 7, signal: null.
[2020-08-04 21:27:48.156] [remoteagent] [info] Last EH closed, waiting before shutting down

@ivensli
Copy link
Author

ivensli commented Aug 5, 2020 •
edited
Loading

@hyangah
OSes
Remote: CentOS 7.2
Source: Windows 10

Go version 1.14.2

Host Logs not found

Remote Logs

[2020-08-04 14:46:17.238] [remoteagent] [info] [127.0.0.1][c4fe4ed8][ExtensionHostConnection] <10780> Extension Host Process exited with code: 7, signal: null.
[2020-08-04 14:46:17.239] [remoteagent] [info] Cancelling previous shutdown timeout

My colleagues also met this problem. We solved this problem by downgrading extention version to 0.15.2.

@hyangah
Copy link
Contributor

hyangah commented Aug 5, 2020

Thanks! I am currently guessing this is also caused by the same bug that caused #469.

I could reproduce a similar reconnection loop by making the extension crash. https://go-review.googlesource.com/c/vscode-go/+/246777 fixed my repro case. Once the fix cl is approved, I will cherry pick for 0.16.1. Sorry for the inconvenience.

@hyangah hyangah added this to the v0.16.1 milestone Aug 5, 2020
@hyangah
Copy link
Contributor

hyangah commented Aug 5, 2020

RC.1 is out. https://github.com/golang/vscode-go/releases/tag/v0.16.1-rc.1

Can you check if the RC1 addresses this issue?

  1. download the vsix file from the link
  2. connect to the remote host
  3. from command palette, "Extensions: Install from VSIX..."
  4. select the downloaded vsix.
  5. reload window.

Thanks a lot! 🙏

@ivensli
Copy link
Author

ivensli commented Aug 6, 2020 •
edited
Loading

@hyangah RC1 works for me. Reconnection never came up again. Thank you for help!

@bmharper
Copy link

bmharper commented Aug 6, 2020

@hyangah RC1 has fixed this issue for me. Thanks!

@jasonkofo
Copy link

@hyangah RC1 has also fixed this issue for me. Thanks!

@hyangah
Copy link
Contributor

hyangah commented Aug 6, 2020

Thanks all for verifying the fix. 0.16.1 is released.

@hyangah hyangah closed this as completed Aug 6, 2020
@golang golang locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
v0.16.1
Development

No branches or pull requests
6 participants
@bmharper @SteveHNH @hyangah @ivensli @gopherbot @jasonkofo