Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METADATA.pb: Move sample_text and sample_glyphs to language textprotos #3754

Open
felipesanches opened this issue Aug 24, 2021 · 1 comment
Assignees

Comments

@felipesanches
Copy link
Collaborator

While updating the METADATA.pb schema description on FontBakery (fonttools/fontbakery#3443) and gf-tools (googlefonts/gf-docs#114), I noticed that some files such as https://github.com/google/fonts/blob/main/ofl/notosansoldpermic/METADATA.pb have sample_text and sample_glyphs entries and this seems redundant to the kind of content I see in some of the language textprotos available at https://github.com/google/fonts/blob/main/lang/languages/

On this specific case, though, https://github.com/google/fonts/blob/main/lang/languages/koi_Perm.textproto and https://github.com/google/fonts/blob/main/lang/languages/kv_Perm.textproto lack such sample entries.

The sample_text and sample_glyphs entries should (in my opinion) migrate to the language textproto files while the languages entries also present on the METADATA.pb file should be enough to cross-reference the lang database:

languages: "koi_Perm"  # Komi-Permyak, Old Permic
languages: "kv_Perm"  # Komi, Old Permic
@felipesanches
Copy link
Collaborator Author

Not sure if there are more of these commits, but at least 398a28a is one place where these entries were added recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants