fix: Change proxy service to call child start methods on executors #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change service clients to use an isolated executor Also change channel pools to not use a fixed pool size, and use an auto-scaling channel pool.
product-auto-label
bot
added
size: m
tmdiep
approved these changes
Feb 20, 2023
google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/ProxyService.java
Outdated
Show resolved
Hide resolved
dpcollins-google
force-pushed
the
fix-executors
branch
from
d521278 to
e1ac568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change service clients to use an isolated executor.
Also change channel pools to not use a fixed pool size, and use an auto-scaling channel pool.