-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update comments for regional topics #967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmenzella-google
approved these changes
Dec 13, 2021
@tmdiep Appears to have some lint complaints. |
@anguillanneuf Thanks! Fixed. |
anguillanneuf
approved these changes
Jan 6, 2022
cb41221
to
59b7647
Compare
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
🤖 I have created a release *beep* *boop* --- ### [1.4.9](v1.4.8...v1.4.9) (2022-02-04) ### Bug Fixes * Ensure messages are delivered in order ([#1031](#1031)) ([a8a969e](a8a969e)) * mitigate gRPC stream connection issues ([#1038](#1038)) ([f3678b7](f3678b7)) * Reinitialize streams in an unbounded executor ([#1027](#1027)) ([6377c1d](6377c1d)) ### Documentation * Update comments for regional topics ([#967](#967)) ([7220439](7220439)) ### Dependencies * update dependency com.google.cloud:google-cloud-bom to v0.166.0 ([#1017](#1017)) ([03ae03a](03ae03a)) * update dependency com.google.cloud:google-cloud-pubsub to v1.115.1 ([#1014](#1014)) ([59e74c9](59e74c9)) * update dependency com.google.cloud:google-cloud-pubsub to v1.115.2 ([#1041](#1041)) ([1f46ca9](1f46ca9)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#1037](#1037)) ([15d4215](15d4215)) * update dependency com.google.errorprone:error_prone_annotations to v2.11.0 ([#1032](#1032)) ([677b96b](677b96b)) * update dependency com.google.errorprone:error_prone_core to v2.11.0 ([#1033](#1033)) ([088cc62](088cc62)) * update dependency org.checkerframework:checker-qual to v3.21.1 ([#1015](#1015)) ([ffa1f0b](ffa1f0b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update comments to indicate that topics may belong to a region or zone.