Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: namespace ACL config typo fix #22166

Merged
merged 1 commit into from
Feb 19, 2025
Merged

docs: namespace ACL config typo fix #22166

merged 1 commit into from
Feb 19, 2025

Conversation

boruszak
Copy link
Contributor

@boruszak boruszak commented Feb 14, 2025 •
edited
Loading

Description

Corrects a typo when the namespace prefix configuration was added in #22162.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Feb 14, 2025
@boruszak boruszak added pr/no-changelog PR does not need a corresponding .changelog entry backport/ent/1.18 Changes are backported to 1.18 ent backport/1.20 Changes are backported to 1.20 backport/ent/1.19 Changes are backported to 1.19 ent labels Feb 14, 2025
@boruszak boruszak marked this pull request as ready for review February 14, 2025 22:37
@boruszak boruszak requested review from a team as code owners February 14, 2025 22:37
@boruszak boruszak merged commit 952f237 into main Feb 19, 2025
100 of 102 checks passed
@boruszak boruszak deleted the docs/namespace-prefix-typo branch February 19, 2025 15:58
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Feb 19, 2025
Merged
4 tasks
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @boruszak! a backport is missing for this PR [22166] for versions [1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

3 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @boruszak! a backport is missing for this PR [22166] for versions [1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @boruszak! a backport is missing for this PR [22166] for versions [1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @boruszak! a backport is missing for this PR [22166] for versions [1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimeeu aimeeu aimeeu approved these changes

Assignees
No one assigned
Labels
backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boruszak @hc-github-team-consul-core @aimeeu