Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract registry factory reading into shared constants in SDK #5543

Open
nambrot opened this issue Feb 21, 2025 · 0 comments
Open

Extract registry factory reading into shared constants in SDK #5543

nambrot opened this issue Feb 21, 2025 · 0 comments
Assignees

Comments

@nambrot
Copy link
Contributor

nambrot commented Feb 21, 2025

We extract registry addresses and then selectively pass them to modules in

const {
domainRoutingIsmFactory,
staticMerkleRootMultisigIsmFactory,
staticMessageIdMultisigIsmFactory,
staticAggregationIsmFactory,
staticAggregationHookFactory,
staticMerkleRootWeightedMultisigIsmFactory,
staticMessageIdWeightedMultisigIsmFactory,
} = registryAddresses[chain];

or

https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/cli/src/deploy/warp.ts#L774-L782

IMO that should be extracted, and expressed as clear "constant"/"configuration" and their purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Sprint
Development

No branches or pull requests

2 participants