-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto bandwidth selection is broken when connecting to a server on the same LAN #6535
Comments
When I try the following steps, I do get a lower bitrate when playing video:
Could you try the same steps and see what happens? |
@viown I tried the same and the auto bandwidth is still broken |
Looks like the legacy apiclient will use a hardcoded bitrate value when it detects it's on the same network, where the bitrate can't go below 140Mbps. Not sure why this is, but I'm also not sure how reliable the test can be at slower connections, but either way, changes to the legacy apiclient are not allowed and the bitrate detection will probably have to be reworked or upstreamed at some point. |
What will need to happen for this to be fixed? |
Originally it was exactly 140Mbps. So as not to break the old behavior, it was limited by this value. The measured bitrate is then reduced (70%).
Move bitrate detection to web. 🤷 |
This issue respects the following points:
Describe the bug
When connecting to a server on the same LAN, the auto bandwidth is always 120mbps regardless of actual speed.
This can be problematic when using VPNs or on clients with bad Wifi reception.
Reproduction Steps
Expected/Actual behaviour
Expected:
The client should select a bitrate based on the actual bandwidth between the server and the client
Actual:
The client selects 120mbps every time and high bitrate video stutters.
Logs
No response
Server version
10.10.3, Unstable
Web version
10.10.3, Unstable
Build version
10.10.3, Unstable
Platform
macOS
Browser
Firefox
Additional information
No response
The text was updated successfully, but these errors were encountered: