Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong/missing commands for extract actions #230

Closed
Eskibear opened this issue Jun 30, 2021 · 1 comment
Closed

wrong/missing commands for extract actions #230

Eskibear opened this issue Jun 30, 2021 · 1 comment
Assignees
@kasecato
Labels
bug enhancement
Milestone
v1.6.0

Comments

@Eskibear
Copy link
Contributor

Extract Variable | ✅

wrong refactoring kind (see here), should be refactor.extract.variable

Extract Field | N/A

refactoring available. should be refactor.extract.field

Extract Constant | N/A

refactoring available. should be refactor.extract.constant (wrongly mapped to "variable" now)

Extract Parameter | N/A

There is a refactoring kind named as refactor.introduce.parameter, please check if it's matched.

Reference

https://github.com/redhat-developer/vscode-java/blob/84d2985555251eaffd22dcb33f711a0e01f28b68/src/codeActionProvider.ts#L4-L18
@kasecato kasecato self-assigned this Oct 29, 2021
@kasecato kasecato added the bug label Feb 23, 2024
@kasecato kasecato added this to the v1.6.0 milestone Feb 23, 2024
@kasecato
Copy link
Owner

These refactoring features is fixed #261

  • Extract Variable
  • Extract Field
  • Extract Constant

These refactoring methods is added #326

  • Extract Parameter
  • Change Signature

I was really surprised that vscode-java supported the Change Signature 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasecato kasecato

Labels
bug enhancement
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
2 participants
@Eskibear @kasecato