Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Service Broker timeout is not configurable #2657

Closed
fmui opened this issue Jun 12, 2019 · 5 comments
Closed

Service Broker timeout is not configurable #2657

fmui opened this issue Jun 12, 2019 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@fmui
Copy link

fmui commented Jun 12, 2019

Bug Report

What happened:

The OSB spec states in the "Orphans" section:

"Orphans can result if the Service Broker does not return a response before a request from the Platform times out (typically 60 seconds)."

The Service Catalog does not allow the configuration of this timeout, but always waits for 60 seconds. The spec would also allow a different (longer) timeout.
In some scenarios, brokers may need slightly more than 60 seconds to wake up and execute the request.

What you expected to happen:

There should be a way to set the timeout globally and per broker.

@jberkhahn
Copy link
Contributor

making this globally configurable wouldn't be too difficult. making it configurable per-broker would require a bit of plumbing, but is still doable.

in either case, this will likely have to wait until repo migration of our OSB client is complete, as we currently don't have access to the repo.

@mszostok
Copy link
Contributor

mszostok commented Jun 19, 2019

The global timeout will be added in this PR: #2666

about setting that per broker, we can do it in the same manner that we have for the relisting, we have a global configurable param broker-relist-interval and also additional field RelistDuration directly in Broker Spec, thanks to that you can always override that.

So for Timeout we can have:

  • osb-api-request-timeout-duration param globally for controller manager
  • RequestTimeoutDuration directly in Broker Spec

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2019
@jberkhahn
Copy link
Contributor

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 18, 2019
@mrbobbytables
Copy link

This project is being archived, closing open issues and PRs.
Please see this PR for more information: kubernetes/community#6632

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants