Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the ´compare´ tool #363

Open
andlaus opened this issue Nov 20, 2024 · 4 comments
Open

refactor the ´compare´ tool #363

andlaus opened this issue Nov 20, 2024 · 4 comments
Labels
enhancement New feature or request good first contribution Good for newcomers help wanted Extra attention is needed

Comments

@andlaus
Copy link
Member

andlaus commented Nov 20, 2024 •
edited
Loading

the code of the compare tool currently is a bowl of spaghetti with sub-optimal type annotations (lots of type: ignore comments) and desperately needs a cleanup.
@andlaus andlaus added enhancement New feature or request good first contribution Good for newcomers help wanted Extra attention is needed labels Nov 20, 2024
@andlaus andlaus mentioned this issue Nov 20, 2024
Merged
@vinothk-master
Copy link

Hi @andlaus
Can I contribute to this open issue?
Thanks
Vinoth Kannan

@andlaus
Copy link
Member Author

andlaus commented Feb 20, 2025

sure, that would be much appreciated. if you're looking for a place to start, a great one would to refactor the code to making use of dataclasses in order to make it easier to understand what data is expected/available where and to get rid (or at least reduce the number) of type: ignore comments...

@vinothk-master
Copy link

Ok @andlaus Thanks for the info, Let me check the code first
Thanks

@vinothk-master
Copy link

Hi @andlaus

Status: I am working on implementing the @dataclass as you mentioned and trying to reduce the type: ignore comments

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first contribution Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andlaus @vinothk-master