Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench.action.maximizeEditor command is missing #197227

Closed
AnrDaemon opened this issue Nov 2, 2023 · 6 comments
Closed

workbench.action.maximizeEditor command is missing #197227

AnrDaemon opened this issue Nov 2, 2023 · 6 comments
Assignees

Comments

@AnrDaemon
Copy link

Type: Bug

I've had a keybind bound to the workbench.action.maximizeEditor command I've been using repeatedly. Now it is gone.

The new workbench.action.maximizeEditorHideSidebar is a no replacement for it, as it hides all other editor groups. Not what I wanted from it. I still need other group's tabs clearly visible, as they are opened project files I use as references. Sometimes opening them side by side, sometimes collapsing to only the headers. But never I want them hidden.

VS Code version: Code 1.84.0 (d037ac0, 2023-11-01T11:29:04.398Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i3-8145U CPU @ 2.10GHz (4 x 2304)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 7.86GB (1.15GB free)
Process Argv --folder-uri file:///d%3A/Profiles/anrdaemon/Documents/hk/invapi-php
Screen Reader no
VM 0%
@AnrDaemon
Copy link
Author

An alternate solution for me would be to allow the so-called "web panels" - side bar panels containing open project files, read-only with a button to reopen them for editing.

@bpasero bpasero assigned benibenj and unassigned bpasero Nov 2, 2023
@benibenj
Copy link
Contributor

benibenj commented Nov 2, 2023

We renamed the old maximize feature to expand. You can use the Expand Editor Group (workbench.action.minimizeOtherEditors) command.

@benibenj benibenj closed this as completed Nov 2, 2023
@AnrDaemon
Copy link
Author

The workbench.action.minimizeOtherEditorsHideSidebar command would be a good addition to the mix.

@benibenj
Copy link
Contributor

benibenj commented Nov 2, 2023

You are right, I will add it back. Until it's available, you can use the workbench.action.closeSidebar command together with workbench.action.minimizeOtherEditors.

@AnrDaemon
Copy link
Author

Sorry, I don't quite get it. How would I call two commands with a single keybind?

@benibenj
Copy link
Contributor

benibenj commented Nov 2, 2023

You can run multiple commands with a single shortcut in the following way:
Add this to your keybindings.json file
{ "key": "ctrl+k", "command": "runCommands", "args": { "commands": [ "workbench.action.closeSidebar", "workbench.action.minimizeOtherEditors" ] } }

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants