Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colored hot cue button support to skins #9663

Closed
mixxxbot opened this issue Aug 23, 2022 · 5 comments
Closed

Add colored hot cue button support to skins #9663

mixxxbot opened this issue Aug 23, 2022 · 5 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: Holzhaus
Date: 2019-05-21T15:11:07Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp1829884


If a custom hot cue color is set, the hot cue buttons in the skins should be painted in the chosen color.

Related to https://bugs.launchpad.net/mixxx/+bug/1367162

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2019-05-30T12:31:59Z


Done for Deere and Tango: #2120

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-07-06T13:10:56Z


I'll take a look how we can slove this for LateNight as well.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-07-07T12:58:29Z


@jan Holzhuis did the major part, the implementation for Deere, Shade & Tango in
#2120

In LateNight it's a bit more complicated as the bg colors are in the SVGs.
I'll test if SVG transparency gradients work, then it should be easy to use bg colors per hotcue "highlight" as in the other skins

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-07-18T17:36:23Z


ronso0 fixed this with #2205 and PR has been merged.
setting to fix committed.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant